linux-kernel - Re: [PATCH] phy: qcom: remove ufs qmp phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200630045426.GO2599@vkoul-mobl>
Date:   Tue, 30 Jun 2020 10:24:26 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: qcom: remove ufs qmp phy driver

Hi Bjorn,

On 29-06-20, 12:24, Bjorn Andersson wrote:
> On Mon 29 Jun 07:54 PDT 2020, Vinod Koul wrote:
> 
> > UFS QMP phy drivers are duplicate as we are supposed to use common QMP
> > phy driver which is working fine on various platforms. So remove the
> > unused driver
> > 
> 
> This describes the current state, but the UFS QMP driver had a purpose
> not that long ago and I would like the commit message to describe what
> changed and why it's now fine to remove the driver.

Would below look better, also feel free to suggest as you have the
more history on this :)

"UFS QMP driver is dedicated driver for QMP phy for UFS variant. We
also have a common QMP phy driver which works not only for UFS but
USB and PCIe as well, so retire this driver in favour of the common
driver"

> 
> I'm happy with the patch itself (i.e. the removal of the driver) though.

Thanks
-- 
~Vinod