linux-kernel - Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1593502139.23885.5.camel@mhfsdcap03>
Date:   Tue, 30 Jun 2020 15:28:59 +0800
From:   Chunfeng Yun <chunfeng.yun@...iatek.com>
To:     Markus Elfring <Markus.Elfring@....de>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        Colin Ian King <colin.king@...onical.com>
Subject: Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference

On Mon, 2020-06-29 at 10:00 +0200, Markus Elfring wrote:
> > Some pointers are dereferenced before successful checks.
> 
> I suggest to reconsider and improve the change description.
> 
> * Would a null pointer dereference be possible only with the variables “mep”
>   and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?
> 
> * How do you think about to adjust any more variable initialisations?
Yes, I'll do it if need, thanks

> 
> * Will it become helpful to add the tag “Fixes” to the commit message?
Maybe needn't

> 
> Regards,
> Markus