linux-kernel - Re: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200630081247.GI1179328@dell>
Date:   Tue, 30 Jun 2020 09:12:47 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     haver <haver@...ux.vnet.ibm.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Michael Jung <mijung@....net>,
        Michael Ruettger <michael@...ra.de>,
        Frank Haverkamp <haver@...ux.ibm.com>,
        Joerg-Stephan Vogt <jsvogt@...ibm.com>
Subject: Re: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused
 variable 'rc'

On Tue, 30 Jun 2020, haver wrote:

> On 2020-06-30 09:42, Lee Jones wrote:
> > On Tue, 30 Jun 2020, haver wrote:
> > 
> > > On 2020-06-29 16:04, Lee Jones wrote:
> > > > Variable 'rc' hasn't been checked since the driver's inception
> > > > in 2013.  If it hasn't caused any issues since then, it's unlikely
> > > > to in the future.  Let's take it out for now.
> > > >
> > > > Fixes the following W=1 kernel build warning(s):
> > > >
> > > >  drivers/misc/genwqe/card_base.c: In function
> > > > ‘genwqe_health_check_stop’:
> > > >
> > > > /home/lee/projects/linux/kernel/drivers/misc/genwqe/card_base.c:1046:6:
> > > > warning: variable ‘rc’ set but not used
> > > > [-Wunused-but-set-variable]
> > > >  1046 | int rc;
> > > >  | ^~
> > > >
> > > > Cc: Michael Jung <mijung@....net>
> > > > Cc: Michael Ruettger <michael@...ra.de>
> > > > Cc: Frank Haverkamp <haver@...ux.ibm.com>
> > > > Cc: Joerg-Stephan Vogt <jsvogt@...ibm.com>
> > > > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > > > ---
> > > >  drivers/misc/genwqe/card_base.c | 4 +---
> > > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/misc/genwqe/card_base.c
> > > > b/drivers/misc/genwqe/card_base.c
> > > > index 1dc6c7c5cbce9..bceebf49de2d5 100644
> > > > --- a/drivers/misc/genwqe/card_base.c
> > > > +++ b/drivers/misc/genwqe/card_base.c
> > > > @@ -1043,12 +1043,10 @@ static int genwqe_health_thread_running(struct
> > > > genwqe_dev *cd)
> > > >
> > > >  static int genwqe_health_check_stop(struct genwqe_dev *cd)
> > > >  {
> > > > -	int rc;
> > > > -
> > > >  	if (!genwqe_health_thread_running(cd))
> > > >  		return -EIO;
> > > >
> > > > -	rc = kthread_stop(cd->health_thread);
> > > > +	kthread_stop(cd->health_thread);
> > > >  	cd->health_thread = NULL;
> > > >  	return 0;
> > > >  }
> > > 
> > > Good idea. Let's remove it Thanks for the contribution.
> > 
> > No problem, and you are welcome.
> > 
> > > Signed-off-by: Frank Haverkamp <haver@...ux.ibm.com>
> > 
> > Just as an aside, this should be Acked-by, unless you either
> > contributed to the patch directly or are in the delivery path i.e. you
> > plan to pick the patch and send it to, say Linus, via a pull-request.
> 
> Right. Thanks for reminding me. Feel free to send it yourself.
> When was the documentation checking introduced? At the time we
> contributed the code there was no such checking.

The checking scripts have been in place for many years, but it looks
like doc checking became part of EXTRA_GCC_CHECKS builds in 2017:

> commit 3a025e1d1c2ea42fa497c9c6b21c284e0f69e28b
Author: Matthew Wilcox <willy@...radead.org>
Date:   Mon Nov 20 10:40:40 2017 -0800

    Add optional check for bad kernel-doc comments
    
    Implement a '-none' output mode for kernel-doc which will only output
    warning messages, and suppresses the warning message about there being
    no kernel-doc in the file.
    
    If the build has requested additional warnings, automatically check all
    .c files.  This patch does not check .h files.  Enabling the warning
    by default would add about 1300 warnings, so it's default off for now.
    People who care can use this to check they didn't break the docs and
    maybe we'll get all the warnings fixed and be able to enable this check
    by default in the future.
    
    Signed-off-by: Matthew Wilcox <mawilcox@...rosoft.com>
    Signed-off-by: Jonathan Corbet <corbet@....net>

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 2e3a10e79ca9e..aceac0ba07451 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -108,6 +108,10 @@ ifneq ($(KBUILD_CHECKSRC),0)
   endif
 endif
 
+ifneq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),)
+  cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $< ;
+endif
+
 # Do section mismatch analysis for each module/built-in.o
 ifdef CONFIG_DEBUG_SECTION_MISMATCH
   cmd_secanalysis = ; scripts/mod/modpost $@
@@ -289,6 +293,7 @@ define rule_cc_o_c
        $(call echo-cmd,checksrc) $(cmd_checksrc)                         \
        $(call cmd_and_fixdep,cc_o_c)                                     \
        $(cmd_modversions_c)                                              \
+       $(cmd_checkdoc)                                                   \
        $(call echo-cmd,objtool) $(cmd_objtool)                           \
        $(call echo-cmd,record_mcount) $(cmd_record_mcount)
 endef

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog