linux-kernel - Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Jun 2020 12:53:42 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Sungbo Eo <mans0n@...ani.run>,
        Linus Walleij <linus.walleij@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

On Tue, Jun 30, 2020 at 12:28 PM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
> On Thu, Jun 25, 2020 at 9:58 AM Sungbo Eo <mans0n@...ani.run> wrote:

> > +static const struct of_device_id pca9570_of_match_table[] = {
> > +       { .compatible = "nxp,pca9570" },
> > +       { /* sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, pca9570_of_match_table);
>
> If you're not using it in probe than maybe move it next to the I2C device table?

(Side note)
...and even if so it can be assessed via a struct device pointer:
dev->driver->id_table (don't remember by heart, but you have an idea).

-- 
With Best Regards,
Andy Shevchenko