linux-kernel - Re: [PATCH v7 2/4] driver core: add deferring probe reason to devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Jun 2020 13:00:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Andrzej Hajda <a.hajda@...sung.com>
Cc:     Jernej Skrabec <jernej.skrabec@...l.net>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jonas Karlman <jonas@...boo.se>,
        Mark Brown <broonie@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v7 2/4] driver core: add deferring probe reason to
 devices_deferred property

On Tue, Jun 30, 2020 at 11:32 AM Andrzej Hajda <a.hajda@...sung.com> wrote:
> On 29.06.2020 18:36, Andy Shevchenko wrote:
> > On Mon, Jun 29, 2020 at 2:22 PM Andrzej Hajda <a.hajda@...sung.com> wrote:
> >> /sys/kernel/debug/devices_deferred property contains list of deferred devices.
> >> This list does not contain reason why the driver deferred probe, the patch
> >> improves it.
> >> The natural place to set the reason is dev_err_probe function introduced recently,
> >> ie. if dev_err_probe will be called with -EPROBE_DEFER instead of printk the message
> >> will be attached to deferred device and printed when user read devices_deferred
> > to a deferred
> >
> > reads
> OK, thx.
> >
> >> property.

...

> >>          list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe)
> >> -               seq_printf(s, "%s\n", dev_name(curr->device));
> >> +               seq_printf(s, "%s\t%s", dev_name(curr->device),
> >> +                          curr->device->p->deferred_probe_reason ?: "\n");
> > Hmm... "\t" will be dangling in the latter case
>
>
> Hmm, I followed your advice [1] :)
>
> [1]:
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1787370.html

Ah, indeed :-)
Okay, as I  said I'm fine with the code. Since it's debugfs, we are fine.

-- 
With Best Regards,
Andy Shevchenko