linux-kernel - Re: [PATCH 04/10] gpio: gpio-pmic-eic-sprd: Fix incorrectly named property 'map'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADBw62ozqWk7qYpsJsWSC1ZH6kZk9giMwWfw3=Wb+=7qONe7jw@mail.gmail.com>
Date:   Tue, 30 Jun 2020 23:01:53 +0800
From:   Baolin Wang <baolin.wang7@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        bgolaszewski@...libre.com, linux-arm-kernel@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>, linux-gpio@...r.kernel.org,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH 04/10] gpio: gpio-pmic-eic-sprd: Fix incorrectly named
 property 'map'

On Tue, Jun 30, 2020 at 9:33 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> A good attempt has been made to properly document 'struct
> sprd_pmic_eic', but 'map' has been incorrectly described as
> 'regmap' since the driver's inception in 2018.
>
> Fixes the following W=1 kernel build warning:
>
>  drivers/gpio/gpio-pmic-eic-sprd.c:65: warning: Function parameter or member 'map' not described in 'sprd_pmic_eic'
>
> Cc: Orson Zhai <orsonzhai@...il.com>
> Cc: Baolin Wang <baolin.wang7@...il.com>
> Cc: Chunyan Zhang <zhang.lyra@...il.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Looks good to me.
Reviewed-by: Baolin Wang <baolin.wang7@...il.com>

> ---
>  drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index 05000cace9b24..9382851905662 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -48,7 +48,7 @@ enum {
>   * struct sprd_pmic_eic - PMIC EIC controller
>   * @chip: the gpio_chip structure.
>   * @intc: the irq_chip structure.
> - * @regmap: the regmap from the parent device.
> + * @map:  the regmap from the parent device.
>   * @offset: the EIC controller's offset address of the PMIC.
>   * @reg: the array to cache the EIC registers.
>   * @buslock: for bus lock/sync and unlock.
> --
> 2.25.1
>


-- 
Baolin Wang