linux-kernel - Re: [PATCH -next] f2fs: make __allocate_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Jul 2020 09:16:18 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     hulkcommits@...wei.com, Chao Yu <chao@...nel.org>,
        Hulk Robot <hulkci@...wei.com>,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] f2fs: make __allocate_new_segment() static

On 07/01, Wei Yongjun wrote:
> From: Hulk Robot <hulkci@...wei.com>
> 
> From: Hulk Robot <hulkci@...wei.com>
> 
> Fix sparse build warning:
> 
> fs/f2fs/segment.c:2736:6: warning:
>  symbol '__allocate_new_segment' was not declared. Should it be static?

It was fixed.
https://lore.kernel.org/linux-f2fs-devel/20200701042222.GA1539525@google.com/T/#m9667447e4d37672e26dee7e30896d129eac1c479

> 
> Signed-off-by: Hulk Robot <hulkci@...wei.com>
> ---
>  fs/f2fs/segment.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index b45e473508a9..c35614d255e1 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2733,7 +2733,7 @@ void f2fs_allocate_segment_for_resize(struct f2fs_sb_info *sbi, int type,
>  	up_read(&SM_I(sbi)->curseg_lock);
>  }
>  
> -void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> +static void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
>  {
>  	struct curseg_info *curseg = CURSEG_I(sbi, type);
>  	unsigned int old_segno;