linux-kernel - Re: [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78C72279-99DB-4FDE-81B3-1CF6BEF80BBF@aosc.io>
Date:   Wed, 01 Jul 2020 20:01:14 +0800
From:   Icenowy Zheng <icenowy@...c.io>
To:     Ondrej Jirman <megous@...ous.com>, linux-sunxi@...glegroups.com,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Guido Günther <agx@...xcpu.org>,
        Purism Kernel Team <kernel@...i.sm>,
        Rob Herring <robh+dt@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Linus Walleij <linus.walleij@...aro.org>
CC:     dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Samuel Holland <samuel@...lland.org>,
        Martijn Braam <martijn@...xit.nl>, Luca Weiss <luca@...tu.xyz>,
        Bhushan Shah <bshah@....org>
Subject: Re: [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support



于 2020年7月1日 GMT+08:00 下午6:31:26, Ondrej Jirman <megous@...ous.com> 写到:
>Pinephone has a Goodix GT917S capacitive touchscreen controller on
>I2C0 bus. Add support for it.
>
>Signed-off-by: Ondrej Jirman <megous@...ous.com>
>Acked-by: Linus Walleij <linus.walleij@...aro.org>
>---
> .../dts/allwinner/sun50i-a64-pinephone.dtsi   | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
>b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
>index 85a7aa5efd32..2d5694446d17 100644
>--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
>+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
>@@ -123,6 +123,25 @@ &ehci1 {
> 	status = "okay";
> };
> 
>+&i2c0 {
>+	pinctrl-names = "default";
>+	pinctrl-0 = <&i2c0_pins>;
>+	status = "okay";
>+
>+	touchscreen@5d {
>+		compatible = "goodix,gt917s", "goodix,gt911";

Please drop gt911 here. GT917S belong to the GT1x product line, not the same line with GT911.

You will see this in the driver.

>+		reg = <0x5d>;
>+		interrupt-parent = <&pio>;
>+		interrupts = <7 4 IRQ_TYPE_LEVEL_HIGH>; /* PH4 */
>+		irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
>+		reset-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */
>+		AVDD28-supply = <&reg_ldo_io0>;
>+		VDDIO-supply = <&reg_ldo_io0>;
>+		touchscreen-size-x = <720>;
>+		touchscreen-size-y = <1440>;
>+	};
>+};
>+
> &i2c1 {
> 	status = "okay";
>