linux-kernel - Re: [PATCH] fs/proc: add short desc for /proc/softirqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Jul 2020 21:14:36 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     zhenwei pi <pizhenwei@...edance.com>
Cc:     tglx@...utronix.de, kzak@...hat.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs/proc: add short desc for /proc/softirqs

On Wed, Jul 01, 2020 at 10:35:03PM +0800, zhenwei pi wrote:
> Only softirq name is not friendly to end-users, typically 'HI' is
> difficult to understand. During developing irqtop/lsirq utilities
> for util-linux, Karel Zak considered that we should give more
> information to end-users. Discuss about this:
>     https://github.com/karelzak/util-linux/pull/1079
> 
> Add short desc for /proc/softirqs in this patch, then /proc/softirqs
> gets more human-readable.

> --- a/fs/proc/softirqs.c
> +++ b/fs/proc/softirqs.c
> @@ -20,7 +20,7 @@ static int show_softirqs(struct seq_file *p, void *v)
>  		seq_printf(p, "%12s:", softirq_to_name[i]);
>  		for_each_possible_cpu(j)
>  			seq_printf(p, " %10u", kstat_softirqs_cpu(i, j));
> -		seq_putc(p, '\n');
> +		seq_printf(p, "  %s\n", softirq_to_desc[i]);

This could break parsers. I'd rather leave it as is and update proc(5).

Of course this file doesn't need more characters in it. :-\