linux-kernel - Re: [PATCH] kunit: kunit_config: Fix parsing of CONFIG options with space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da025a82-17ee-e8bb-61dd-e655f0087d8f@linuxfoundation.org>
Date:   Wed, 1 Jul 2020 13:10:34 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     David Gow <davidgow@...gle.com>,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        masahiroy@...nel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        skhan@...uxfoundation.org
Subject: Re: [PATCH] kunit: kunit_config: Fix parsing of CONFIG options with
 space

On 6/30/20 1:15 AM, David Gow wrote:
> On Mon, Jun 8, 2020 at 5:57 AM Rikard Falkeborn
> <rikard.falkeborn@...il.com> wrote:
>>
>> Commit 8b59cd81dc5e ("kbuild: ensure full rebuild when the compiler is
>> updated") introduced a new CONFIG option CONFIG_CC_VERSION_TEXT. On my
>> system, this is set to "gcc (GCC) 10.1.0" which breaks KUnit config
>> parsing which did not like the spaces in the string.
>>
>> Fix this by updating the regex to allow strings containing spaces.
>>
>> Fixes: 8b59cd81dc5e ("kbuild: ensure full rebuild when the compiler is updated")
>> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
> 
> Tested-by: David Gow <davidgow@...gle.com>
> 
> I've been using this patch quite a bit, and haven't hit any problems.
> 
> +Shuah: Any chance we get this into the kunit branch sooner rather
> than later? The KUnit tooling is quite broken without it.
> 


Applied to linux-kselftest kunit

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=kunit

thanks,
-- Shuah