linux-kernel - Re: [PATCH net-next 2/4] net: macb: use hweight_long() to count set bits in queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200701.122241.894076396008620124.davem@davemloft.net>
Date:   Wed, 01 Jul 2020 12:22:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     claudiu.beznea@...rochip.com
Cc:     nicolas.ferre@...rochip.com, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/4] net: macb: use hweight_long() to count
 set bits in queue_mask

From: Claudiu Beznea <claudiu.beznea@...rochip.com>
Date: Wed, 1 Jul 2020 16:08:49 +0300

> @@ -3482,8 +3482,6 @@ static void macb_probe_queues(void __iomem *mem,
>  			      unsigned int *queue_mask,
 ...
> +	*num_queues = hweight_long(*queue_mask);

queue_mask is not a long, it is an unsinged int, therefore hweight32() is
probably more appropriate.