linux-kernel - Re: [PATCH 1/5] hwrng: bcm2835 - Constify bcm2835_rng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83b5c8b5-484a-d688-3c22-b15e388575cd@gmail.com>
Date:   Wed, 1 Jul 2020 14:52:36 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-kernel@...r.kernel.org, Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-crypto@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/5] hwrng: bcm2835 - Constify bcm2835_rng_devtype[]



On 7/1/2020 1:09 PM, Rikard Falkeborn wrote:
> bcm2835_rng_devtype[] is not modified and can be made const to allow the
> compiler to put it in read-only memory.
> 
> Before:
>    text    data     bss     dec     hex filename
>    2392     176       0    2568     a08 drivers/char/hw_random/bcm2835-rng.o
> 
> After:
>    text    data     bss     dec     hex filename
>    2464     104       0    2568     a08 drivers/char/hw_random/bcm2835-rng.o
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian