linux-kernel - Re: [PATCH] i2c: algo-pca: Add 0x78 as SCL stuck low status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200701222934.GB3147@kunai>
Date:   Thu, 2 Jul 2020 00:29:34 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc:     "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: algo-pca: Add 0x78 as SCL stuck low status


> Any conclusion on this? I'm still suggesting that just treating 0x78
> and 0x90 as SCL stuck for either chip is the cleanest solution. I
> think I could do something with a fall-through that repeats the check
> with an if which wouldn't be too ugly.

I tried as well and also came up with code which was not very readable
while trying to be clever.

So, I agree. Let's keep things simple and take your original approach.
Can you resend the patch and update the comments to reflect which code
is for which version? And include the other paragraph in your commit
message?

Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)