linux-kernel - Re: [PATCH v2 11/18] media: mtk-vcodec: venc support MIN_OUTPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Jul 2020 11:30:49 +0800
From:   Tiffany Lin <tiffany.lin@...iatek.com>
To:     Alexandre Courbot <acourbot@...omium.org>
CC:     Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        Rui Wang <gtk_ruiwang@...iatek.com>,
        Yunfei Dong <yunfei.dong@...iatek.com>,
        "Pi-Hsun Shih" <pihsun@...omium.org>,
        Maoguang Meng <maoguang.meng@...iatek.com>,
        <linux-media@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 11/18] media: mtk-vcodec: venc support
 MIN_OUTPUT_BUFFERS control

On Fri, 2020-06-26 at 17:04 +0900, Alexandre Courbot wrote:
> This control is required by v4l2-compliance for encoders. A value of 1
> should be suitable for all scenarios.
> 
Acked-by: Tiffany Lin <tiffany.lin@...iatek.com>

> Signed-off-by: Alexandre Courbot <acourbot@...omium.org>
> ---
>  drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> index f2ba19c32400..f833aee4a06f 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
> @@ -1206,6 +1206,8 @@ int mtk_vcodec_enc_ctrls_setup(struct mtk_vcodec_ctx *ctx)
>  
>  	v4l2_ctrl_handler_init(handler, MTK_MAX_CTRLS_HINT);
>  
> +	v4l2_ctrl_new_std(handler, ops, V4L2_CID_MIN_BUFFERS_FOR_OUTPUT,
> +			  1, 1, 1, 1);
>  	v4l2_ctrl_new_std(handler, ops, V4L2_CID_MPEG_VIDEO_BITRATE,
>  			  ctx->dev->venc_pdata->min_bitrate,
>  			  ctx->dev->venc_pdata->max_bitrate, 1, 4000000);