linux-kernel - [PATCH 5.7.y 1/5] exfat: Set the unused characters of FileName field to the value 0000h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200701232024.2083-2-namjae.jeon@samsung.com>
Date:   Thu,  2 Jul 2020 08:20:20 +0900
From:   Namjae Jeon <namjae.jeon@...sung.com>
To:     gregkh@...uxfoundation.org, sashal@...nel.org
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Hyeongseok.Kim" <Hyeongseok@...il.com>,
        Namjae Jeon <namjae.jeon@...sung.com>
Subject: [PATCH 5.7.y 1/5] exfat: Set the unused characters of FileName
 field to the value 0000h

From: "Hyeongseok.Kim" <Hyeongseok@...il.com>

Some fsck tool complain that padding part of the FileName field
is not set to the value 0000h. So let's maintain filesystem cleaner,
as exfat's spec. recommendation.

Fixes: ca06197382bd ("exfat: add directory operations")
Cc: stable@...r.kernel.org # v5.7
Signed-off-by: Hyeongseok.Kim <Hyeongseok@...il.com>
Reviewed-by: Sungjong Seo <sj1557.seo@...sung.com>
Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
---
 fs/exfat/dir.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c
index 4b91afb0f051..349ca0c282c2 100644
--- a/fs/exfat/dir.c
+++ b/fs/exfat/dir.c
@@ -430,10 +430,12 @@ static void exfat_init_name_entry(struct exfat_dentry *ep,
 	ep->dentry.name.flags = 0x0;
 
 	for (i = 0; i < EXFAT_FILE_NAME_LEN; i++) {
-		ep->dentry.name.unicode_0_14[i] = cpu_to_le16(*uniname);
-		if (*uniname == 0x0)
-			break;
-		uniname++;
+		if (*uniname != 0x0) {
+			ep->dentry.name.unicode_0_14[i] = cpu_to_le16(*uniname);
+			uniname++;
+		} else {
+			ep->dentry.name.unicode_0_14[i] = 0x0;
+		}
 	}
 }
 
-- 
2.17.1