linux-kernel - RE: [PATCH v4 4/5] scsi: ufs: L2P map management for HPB read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <231786897.01593564481923.JavaMail.epsvc@epcpadp2>
Date:   Wed, 01 Jul 2020 09:11:09 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     Avri Altman <Avri.Altman@....com>,
        Daejun Park <daejun7.park@...sung.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        "tomas.winkler@...el.com" <tomas.winkler@...el.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sang-yoon Oh <sangyoon.oh@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        yongmyung lee <ymhungry.lee@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        Adel Choi <adel.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>
Subject: RE: [PATCH v4 4/5] scsi: ufs: L2P map management for HPB read

> +static int ufshpb_issue_map_req(struct ufshpb_lu *hpb,
> > +                               struct ufshpb_region *rgn,
> > +                               struct ufshpb_subregion *srgn)
> > +{
> 
> 
> > +
> > +       ret = ufshpb_lu_get(hpb);
> > +       if (unlikely(ret)) {
> > +               dev_notice(&hpb->hpb_lu_dev,
> > +                          "%s: ufshpb_lu_get failed: %d", __func__, ret);
> > +               goto free_map_req;
> > +       }
> > +
> > +       ret = ufshpb_execute_map_req(hpb, map_req);
> > +       if (ret) {
> > +               dev_notice(&hpb->hpb_lu_dev,
> > +                          "%s: issue map_req failed: %d, region %d - %d\n",
> > +                          __func__, ret, srgn->rgn_idx, srgn->srgn_idx);
> > +               ufshpb_lu_put(hpb);
> > +               goto free_map_req;
> > +       }
> Missing closing ufshpb_lu_put?

ufshpb_lu_put() is called at ufshpb_map_req_compl_fn() which is completed
callback function. Callilng ufshpb_lu_put() in ufshpb_issue_map_req() is
used for error handling.

Thanks,
Daejun