linux-kernel - RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zh8j7mkd.fsf@kernel.org>
Date:   Wed, 01 Jul 2020 09:53:54 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Peter Chen <peter.chen@....com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP

Peter Chen <peter.chen@....com> writes:

>  
>> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, unsigned
>> intf, unsigned alt)
>> > >  	/* we know alt == 0, so this is an activation or a reset */
>> > >
>> > >  	if (intf == acm->ctrl_id) {
>> > > -		dev_vdbg(&cdev->gadget->dev,
>> > > -				"reset acm control interface %d\n", intf);
>> > > -		usb_ep_disable(acm->notify);
>> > > +		if (acm->notify->enabled) {
>> > > +			dev_vdbg(&cdev->gadget->dev,
>> > > +					"reset acm control interface %d\n", intf);
>> > > +			usb_ep_disable(acm->notify);
>> > > +		}
>> >
>> > But it does not fix any issues, the usb_ep_disable checks 'enabled' flag.
>> 
>> It generates spurious trace events if you enable them.
>> 
>
> You mean the trace events from core.c? If it is, we could try to improve it
> and indicate it is already enabled or disabled.

I agree :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)