linux-kernel - Re: [PATCH net-next 2/2] pcnet32: Mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200630.181818.960616348417321292.davem@davemloft.net>
Date:   Tue, 30 Jun 2020 18:18:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     kuba@...nel.org, vaibhavgupta40@...il.com, pcnet32@...ntier.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] pcnet32: Mark PM functions as
 __maybe_unused

From: Nathan Chancellor <natechancellor@...il.com>
Date: Tue, 30 Jun 2020 14:00:34 -0700

> In certain configurations without power management support, the
> following warnings happen:
> 
> ../drivers/net/ethernet/amd/pcnet32.c:2928:12: warning:
> 'pcnet32_pm_resume' defined but not used [-Wunused-function]
>  2928 | static int pcnet32_pm_resume(struct device *device_d)
>       |            ^~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/amd/pcnet32.c:2916:12: warning:
> 'pcnet32_pm_suspend' defined but not used [-Wunused-function]
>  2916 | static int pcnet32_pm_suspend(struct device *device_d)
>       |            ^~~~~~~~~~~~~~~~~~
> 
> Mark these functions as __maybe_unused to make it clear to the compiler
> that this is going to happen based on the configuration, which is the
> standard for these types of functions.
> 
> Fixes: a86688fbef1b ("pcnet32: Convert to generic power management")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied.