linux-kernel - Re: [PATCH v2] mfd: axp20x-i2c: Tell the compiler that ACPI functions may not be used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Jul 2020 16:38:14 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Carlo Caione <carlo@...one.org>
Subject: Re: [PATCH v2] mfd: axp20x-i2c: Tell the compiler that ACPI functions
 may not be used

On Wed, Jul 1, 2020 at 3:00 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> ... as is the case when !CONFIG_ACPI.
>
> This squashes the current W=1 kernel builds warning:
>
>  drivers/mfd/axp20x-i2c.c:82:36: warning: ‘axp20x_i2c_acpi_match’ defined but not used [-Wunused-const-variable=]
>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: Carlo Caione <carlo@...one.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Acked-by: Chen-Yu Tsai <wens@...e.org>

>
> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> index 14f9df74f855c..7d08c06de7afc 100644
> --- a/drivers/mfd/axp20x-i2c.c
> +++ b/drivers/mfd/axp20x-i2c.c
> @@ -79,7 +79,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>
> -static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
> +static const struct acpi_device_id __maybe_unused axp20x_i2c_acpi_match[] = {
>         {
>                 .id = "INT33F4",
>                 .driver_data = AXP288_ID,