linux-kernel - Re: [PATCH v5 3/4] dmaengine: mediatek-cqdma: add dma mask for capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1593594109.26931.2.camel@mtkswgap22>
Date:   Wed, 1 Jul 2020 17:01:49 +0800
From:   EastL <EastL.Lee@...iatek.com>
To:     Matthias Brugger <matthias.bgg@...il.com>
CC:     Sean Wang <sean.wang@...iatek.com>, <vkoul@...nel.org>,
        <robh+dt@...nel.org>, <mark.rutland@....com>,
        <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <wsd_upstream@...iatek.com>
Subject: Re: [PATCH v5 3/4] dmaengine: mediatek-cqdma: add dma mask for
 capability

On Fri, 2020-06-19 at 11:39 +0200, Matthias Brugger wrote:
> 
> On 19/06/2020 10:05, EastL wrote:
> > This patch add dma mask for capability.
> > 
> > Signed-off-by: EastL <EastL.Lee@...iatek.com>
> > ---
> >  drivers/dma/mediatek/mtk-cqdma.c | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/drivers/dma/mediatek/mtk-cqdma.c b/drivers/dma/mediatek/mtk-cqdma.c
> > index 905bbcb..ed33c64 100644
> > --- a/drivers/dma/mediatek/mtk-cqdma.c
> > +++ b/drivers/dma/mediatek/mtk-cqdma.c
> > @@ -117,6 +117,7 @@ struct mtk_cqdma_vchan {
> >   * @clk:                    The clock that device internal is using
> >   * @dma_requests:           The number of VCs the device supports to
> >   * @dma_channels:           The number of PCs the device supports to
> > + * @dma_mask:               A mask for DMA capability
> >   * @vc:                     The pointer to all available VCs
> >   * @pc:                     The pointer to all the underlying PCs
> >   */
> > @@ -126,6 +127,7 @@ struct mtk_cqdma_device {
> >  
> >  	u32 dma_requests;
> >  	u32 dma_channels;
> > +	u32 dma_mask;
> >  	struct mtk_cqdma_vchan *vc;
> >  	struct mtk_cqdma_pchan **pc;
> >  };
> > @@ -607,6 +609,21 @@ static int mtk_cqdma_probe(struct platform_device *pdev)
> >  		cqdma->dma_channels = MTK_CQDMA_NR_PCHANS;
> >  	}
> >  
> > +	if (pdev->dev.of_node)
> > +		err = of_property_read_u32(pdev->dev.of_node,
> > +					   "dma-channel-mask",
> > +					   &cqdma->dma_mask);
> > +	if (err) {
> > +		dev_warn(&pdev->dev,
> > +			 "Using 0 as missing dma-channel-mask property\n");
> > +		cqdma->dma_mask = 0;
> > +	}
> > +
> > +	if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(cqdma->dma_mask))) {
> > +		dev_warn(&pdev->dev, "DMA set mask fail\n");
> 
> fail -> failed
> 
> With this:
> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

OK.
> 
> > +		return -EINVAL;
> > +	}
> > +
> >  	cqdma->pc = devm_kcalloc(&pdev->dev, cqdma->dma_channels,
> >  				 sizeof(*cqdma->pc), GFP_KERNEL);
> >  	if (!cqdma->pc)
> >