lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Jul 2020 17:19:28 +0800 From: Tiezhu Yang <yangtiezhu@...ngson.cn> To: Markus Elfring <Markus.Elfring@....de>, Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, Marc Zyngier <maz@...nel.org> Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH v4 04/14] irqchip/davinci-aintc: Fix potential resource leaks On 07/01/2020 04:15 PM, Markus Elfring wrote: > … >> +++ b/drivers/irqchip/irq-davinci-aintc.c >> @@ -96,7 +96,7 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config) >> resource_size(&config->reg)); >> if (!davinci_aintc_base) { >> pr_err("%s: unable to ioremap register range\n", __func__); >> - return; >> + goto err_release; >> } > … > > Can it help to return any error codes? > Would you like to reconsider the function return type? No, the initial aim of this patch is just to fix the potential resource leaks, so I think maybe no need to consider the function return type now. > > Regards, > Markus
Powered by blists - more mailing lists