linux-kernel - RE: [PATCH] ASoC: Intel: bxt-da7219-max98357a: support MAX98390 speaker amp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB43163B1AED403FA32D9AD9FC976C0@DM6PR11MB4316.namprd11.prod.outlook.com>
Date:   Wed, 1 Jul 2020 09:36:13 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC:     "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        "Mark Brown" <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        "Guennadi Liakhovetski" <guennadi.liakhovetski@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        "M, Naveen" <naveen.m@...el.com>, "Zhi, Yong" <yong.zhi@...el.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Libin Yang <libin.yang@...ux.intel.com>,
        "Chiang, Mac" <mac.chiang@...el.com>,
        "Kuninori Morimoto" <kuninori.morimoto.gx@...esas.com>,
        Rander Wang <rander.wang@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        "Song, Chao" <chao.song@...el.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Jason Yan <yanaijie@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: Intel: bxt-da7219-max98357a: support MAX98390
 speaker amp

> 
> this doesn't look too good, the only difference is the addition of
> MAX98090 which should be added in
> SND_SOC_INTEL_DA7219_MAX98357A_GENERIC
> above.

Will do

> 
> i don't think you need a different top-level config, just extend the existing
> one to say MAX98357A or MAX98390.
> 
> [...]
> 

OK. I'll modify the description for MAX98390

> 
> these look like unrelated changes?
> 
> 

Will revert those changes.

> 
> That looks just wrong?
> 
> It would be really odd to list two devices as prerequisites for loading a driver,
> when in practice they are mutually exclusive? Something's broken in
> coreboot if both are present.
> 
> see below what we used for JSL:
> 
> see static struct snd_soc_acpi_codecs jsl_7219_98373_codecs = {
> 	.num_codecs = 1,
> 	.codecs = {"MX98373"}
> };
> 
> static struct snd_soc_acpi_codecs mx98360a_spk = {
> 	.num_codecs = 1,
> 	.codecs = {"MX98360A"}
> };

Err... I misread the snd_soc_acpi_codec_list function and made this error. Will
fix it in the V2 patch. I will also fix the Chrome v4.19 branch. Thank you for the
review.



Regards,
Brent