linux-kernel - Re: [PATCH v2 07/30] misc: vmw_vmci_defs: Mark 'struct vmci_handle VMCI_ANON_SRC_HANDLE' as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200701103351.GE1179328@dell>
Date:   Wed, 1 Jul 2020 11:33:51 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     arnd@...db.de, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, George Zhang <georgezhang@...are.com>
Subject: Re: [PATCH v2 07/30] misc: vmw_vmci_defs: Mark 'struct vmci_handle
 VMCI_ANON_SRC_HANDLE' as __maybe_unused

On Wed, 01 Jul 2020, Lee Jones wrote:

> vmw_vmci_defs.h is included by multiple source files.  Some of which
> do not make use of 'struct vmci_handle VMCI_ANON_SRC_HANDLE' rendering
> it unused.  Ensure the compiler knows that this is in fact intentional
> by marking it as __maybe_unused.  This fixes the following W=1 warnings:
> 
>  In file included from drivers/misc/vmw_vmci/vmci_context.c:8:
>  include/linux/vmw_vmci_defs.h:162:33: warning: ‘VMCI_ANON_SRC_HANDLE’ defined but not used [-Wunused-const-variable=]
>  162 | static const struct vmci_handle VMCI_ANON_SRC_HANDLE = {
>  | ^~~~~~~~~~~~~~~~~~~~
>  In file included from drivers/misc/vmw_vmci/vmci_datagram.c:8:
>  include/linux/vmw_vmci_defs.h:162:33: warning: ‘VMCI_ANON_SRC_HANDLE’ defined but not used [-Wunused-const-variable=]
>  162 | static const struct vmci_handle VMCI_ANON_SRC_HANDLE = {
> | ^~~~~~~~~~~~~~~~~~~~
> 
> Cc: George Zhang <georgezhang@...are.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  arch/arm/mach-omap2/mmc.h              | 4 ----
>  drivers/mmc/host/omap.c                | 1 -
>  include/linux/platform_data/mmc-omap.h | 3 +++
>  include/linux/vmw_vmci_defs.h          | 2 +-
>  4 files changed, 4 insertions(+), 6 deletions(-)

Drop this please.  Something went wrong.

I will resend it separately in a few days.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog