linux-kernel - Re: [PATCH] mmc: sdhci-acpi: For amd device set driver type as MMC_SET_DRIVER_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b51faa2a-f465-581b-05bc-81677c8c1071@intel.com>
Date:   Wed, 1 Jul 2020 13:43:40 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Akshu Agrawal <akshu.agrawal@....com>
Cc:     rrangel@...gle.com, nehal-bakulchandra.shah@....com,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc@...r.kernel.org, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-acpi: For amd device set driver type as
 MMC_SET_DRIVER_TYPE_A

On 23/06/20 4:33 pm, Akshu Agrawal wrote:
> HS400/HS200/eMMC HS doesn't have Preset Value register.
> Hence, sdhci_set_ios function overrides the value set by fmw to
> SDHCI_CTRL_DRV_TYPE_B.
> This patch sets drv_type to MMC_SET_DRIVER_TYPE_A
> so that host_control2 register gets updated with the required
> strength value.
> 
> Signed-off-by: Akshu Agrawal <akshu.agrawal@....com>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>

> ---
>  drivers/mmc/host/sdhci-acpi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index d8b76cb8698a..48ecbd0b180d 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -542,6 +542,7 @@ static int amd_select_drive_strength(struct mmc_card *card,
>  				     unsigned int max_dtr, int host_drv,
>  				     int card_drv, int *drv_type)
>  {
> +	*drv_type = MMC_SET_DRIVER_TYPE_A;
>  	return MMC_SET_DRIVER_TYPE_A;
>  }
>  
>