linux-kernel - Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200701135543.GA2599@vkoul-mobl>
Date:   Wed, 1 Jul 2020 19:25:43 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Tobias Klauser <tklauser@...tanz.ch>,
        Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning

Hi Laurent,

On 01-07-20, 16:44, Laurent Pinchart wrote:

> > How about marking it as __maybe_unused instead?
> 
> I don't mind either, I'll let Tobias decide, but his patch seems fine,
> is there a drawback in his approach ? If it's just a matter of personal
> preference, I'd rather not require a v2.

__maybe_unused is the preferred way to do as Documented in
Documentation/process/coding-style.rst and makes code look neater..

Thanks
-- 
~Vinod