linux-kernel - Re: [PATCH v2] phy: zynqmp: Fix unused-function compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200701150550.GD2599@vkoul-mobl>
Date:   Wed, 1 Jul 2020 20:35:50 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Michal Simek <michal.simek@...inx.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] phy: zynqmp: Fix unused-function compiler warning

On 01-07-20, 16:10, Tobias Klauser wrote:
> Mark xpsgtr_suspend and xpsgtr_resume as __maybe_unused to fix the
> following compiler warning when building with !CONFIG_PM_SLEEP:
> 
> drivers/phy/xilinx/phy-zynqmp.c:830:12: warning: ‘xpsgtr_resume’ defined but not used [-Wunused-function]
>   830 | static int xpsgtr_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~
> drivers/phy/xilinx/phy-zynqmp.c:819:12: warning: ‘xpsgtr_suspend’ defined but not used [-Wunused-function]
>   819 | static int xpsgtr_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~
> 
> Also drop the existing #ifdef CONFIG_PM so the functions are always
> compile-checked regardless of CONFIG_PM and/or CONFIG_PM_SLEEP being
> set.

Applied, thanks

-- 
~Vinod