linux-kernel - Re: [patch 10/13] Delete SGI UV1 detection.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXE63uh2QhN1mrdSjwNM6yQqM7EY1kRnLBEmdeLovXYmSQ@mail.gmail.com>
Date:   Wed, 1 Jul 2020 17:25:04 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Steve Wahl <steve.wahl@....com>
Cc:     Jonathan Corbet <corbet@....net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        X86 ML <x86@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>,
        Juergen Gross <jgross@...e.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Oliver Neukum <oneukum@...e.com>,
        Mike Travis <mike.travis@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Benjamin Thiel <b.thiel@...teo.de>,
        Andy Lutomirski <luto@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        James Morris <jmorris@...ei.org>,
        David Howells <dhowells@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Dave Young <dyoung@...hat.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Austin Kim <austindh.kim@...il.com>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-efi <linux-efi@...r.kernel.org>,
        Russ Anderson <rja@....com>
Subject: Re: [patch 10/13] Delete SGI UV1 detection.

On Wed, 1 Jul 2020 at 16:18, <steve.wahl@....com> wrote:
>
> As a part of UV1 platform removal, don't try to recognize the platform
> through DMI to set the EFI_UV1_MEMMAP bit.
>
> Signed-off-by: Steve Wahl <steve.wahl@....com>

Reviewed-by: Ard Biesheuvel <ardb@...nel.org>

> ---
>  arch/x86/platform/efi/quirks.c |   23 -----------------------
>  1 file changed, 23 deletions(-)
>
> --- linux.orig/arch/x86/platform/efi/quirks.c   2020-06-17 14:29:45.510015978 -0500
> +++ linux/arch/x86/platform/efi/quirks.c        2020-06-17 14:36:34.473414139 -0500
> @@ -558,16 +558,6 @@ out:
>         return ret;
>  }
>
> -static const struct dmi_system_id sgi_uv1_dmi[] __initconst = {
> -       { NULL, "SGI UV1",
> -               {       DMI_MATCH(DMI_PRODUCT_NAME,     "Stoutland Platform"),
> -                       DMI_MATCH(DMI_PRODUCT_VERSION,  "1.0"),
> -                       DMI_MATCH(DMI_BIOS_VENDOR,      "SGI.COM"),
> -               }
> -       },
> -       { } /* NULL entry stops DMI scanning */
> -};
> -
>  void __init efi_apply_memmap_quirks(void)
>  {
>         /*
> @@ -579,17 +569,6 @@ void __init efi_apply_memmap_quirks(void
>                 pr_info("Setup done, disabling due to 32/64-bit mismatch\n");
>                 efi_memmap_unmap();
>         }
> -
> -       /* UV2+ BIOS has a fix for this issue.  UV1 still needs the quirk. */
> -       if (dmi_check_system(sgi_uv1_dmi)) {
> -               if (IS_ENABLED(CONFIG_X86_UV)) {
> -                       set_bit(EFI_UV1_MEMMAP, &efi.flags);
> -               } else {
> -                       pr_warn("EFI runtime disabled, needs CONFIG_X86_UV=y on UV1\n");
> -                       clear_bit(EFI_RUNTIME_SERVICES, &efi.flags);
> -                       efi_memmap_unmap();
> -               }
> -       }
>  }
>
>  /*
> @@ -723,8 +702,6 @@ void efi_recover_from_page_fault(unsigne
>
>         /*
>          * Make sure that an efi runtime service caused the page fault.
> -        * "efi_mm" cannot be used to check if the page fault had occurred
> -        * in the firmware context because the UV1 memmap doesn't use efi_pgd.
>          */
>         if (efi_rts_work.efi_rts_id == EFI_NONE)
>                 return;
>