linux-kernel - Re: [PATCH net] net: dsa: microchip: set the correct number of ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1133ac51-bdda-1005-8afd-75dd1d53cea8@microchip.com>
Date:   Thu, 2 Jul 2020 15:16:01 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Woojung.Huh@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <vivien.didelot@...il.com>, <f.fainelli@...il.com>,
        <davem@...emloft.net>, <kuba@...nel.org>
Subject: Re: [PATCH net] net: dsa: microchip: set the correct number of ports

On 02.07.2020 16:50, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Jul 02, 2020 at 12:44:50PM +0300, Codrin Ciubotariu wrote:
>> The number of ports is incorrectly set to the maximum available for a DSA
>> switch. Even if the extra ports are not used, this causes some functions
>> to be called later, like port_disable() and port_stp_state_set(). If the
>> driver doesn't check the port index, it will end up modifying unknown
>> registers.
>>
>> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> Thanks for the minimum patch.
> 
> If you wait about a week, net will get merged into net-next. You can
> then submit a refactoring patch based on your previous version.
> 
>      Andrew
> 


Sure thing. This small version does the job, so I will see about the 
refactoring, maybe I will group it with something else...

Thank you for your review!

Best regards,
Codrin