linux-kernel - Re: [PATCH v4] mm, slab: Check GFP_SLAB_BUG_MASK before alloc_pages in kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200702171452.GZ25523@casper.infradead.org>
Date:   Thu, 2 Jul 2020 18:14:52 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Long Li <lonuxli.64@...il.com>
Cc:     cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] mm, slab: Check GFP_SLAB_BUG_MASK before alloc_pages
 in kmalloc_order

On Thu, Jul 02, 2020 at 03:27:59PM +0000, Long Li wrote:
> ---
> changes in V4:
> -Change the check function name to kmalloc_check_flags()
> -Put the flags check into the kmalloc_check_flags() 

The point of not doing that was that this is unlikely().  With your
change there is now a function call to check something that's (extremely)
unlikely().

I take David's point that I misnamed the function.  maybe kmalloc_fix_flags()?