linux-kernel - Re: [PATCH v5 01/10] dt-bindings: dmaengine: convert Actions Semi Owl SoCs bindings to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200702210014.GA1685248@bogus>
Date:   Thu, 2 Jul 2020 15:00:14 -0600
From:   Rob Herring <robh@...nel.org>
To:     Amit Singh Tomar <amittomer25@...il.com>
Cc:     linux-kernel@...r.kernel.org, afaerber@...e.de,
        andre.przywara@....com, cristian.ciocaltea@...il.com,
        robh+dt@...nel.org, vkoul@...nel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        manivannan.sadhasivam@...aro.org, dan.j.williams@...el.com,
        linux-actions@...ts.infradead.org
Subject: Re: [PATCH v5 01/10] dt-bindings: dmaengine: convert Actions Semi
 Owl SoCs bindings to yaml

On Thu, 02 Jul 2020 20:22:47 +0530, Amit Singh Tomar wrote:
> Converts the device tree bindings for the Actions Semi Owl SoCs DMA
> Controller over to YAML schemas.
> 
> It also adds new compatible string "actions,s700-dma".
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Amit Singh Tomar <amittomer25@...il.com>
> ---
> Changes since v4:
> 	* Added Rob's Reviewed-by tag.
> 	* Re-order it from 05/10 to 01/10.
> Changes since v3:
>         * No change.
> Changes since v2:
>         * Addressed Rob's comments:
>            - removed unnecessary description.
>            - added unevaluatedProperties
>            - added relevant information about
>              dma-channels and dma-request
>         * Added power-domain property.
> Change since v1:
>         * Updated the description field to reflect
>           only the necessary information.
>         * replaced the maxItems field with description for each
>           controller attribute(except interrupts).
>         * Replaced the clock macro with number to keep the example
>           as independent as possible.
> ---
>  Documentation/devicetree/bindings/dma/owl-dma.txt  | 47 -------------
>  Documentation/devicetree/bindings/dma/owl-dma.yaml | 79 ++++++++++++++++++++++
>  2 files changed, 79 insertions(+), 47 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/dma/owl-dma.txt
>  create mode 100644 Documentation/devicetree/bindings/dma/owl-dma.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/owl-dma.example.dt.yaml: example-0: dma-controller@...60000:reg:0: [0, 3760586752, 0, 4096] is too long


See https://patchwork.ozlabs.org/patch/1321538

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.