[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAK7LNAQ6SdeWvXj7nNtzMBN2E-s4PmGg6gj7OZHug2_TBKTg1w@mail.gmail.com>
Date: Thu, 2 Jul 2020 11:41:52 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Max Filippov <jcmvbkbc@...il.com>
Cc: linux-kbuild <linux-kbuild@...r.kernel.org>,
Sam Ravnborg <sam@...nborg.org>,
LKML <linux-kernel@...r.kernel.org>,
Chris Zankel <chris@...kel.net>,
"open list:TENSILICA XTENSA PORT (xtensa)"
<linux-xtensa@...ux-xtensa.org>, Guan Xuetao <gxt@....edu.cn>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH] kbuild: do not export LDFLAGS_vmlinux
On Thu, Jul 2, 2020 at 5:14 AM Max Filippov <jcmvbkbc@...il.com> wrote:
>
> On Wed, Jul 1, 2020 at 12:30 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> [...]
>
> > diff --git a/arch/xtensa/boot/boot-elf/Makefile b/arch/xtensa/boot/boot-elf/Makefile
> > index 12ae1e91cb75..c6538d3321b9 100644
> > --- a/arch/xtensa/boot/boot-elf/Makefile
> > +++ b/arch/xtensa/boot/boot-elf/Makefile
> > @@ -25,7 +25,7 @@ $(obj)/Image.o: vmlinux.bin $(OBJS)
> > $(OBJS) $@
> >
> > $(obj)/../Image.elf: $(obj)/Image.o $(obj)/boot.lds
> > - $(Q)$(LD) $(KBUILD_LDFLAGS) $(LDFLAGS_vmlinux) \
> > + $(LD) $(KBUILD_LDFLAGS) \
>
> Can that $(Q) be retained, please?
> The rest LGTM.
Oops, I temporarily deleted $(Q) for debugging,
then accidentally committed it.
I will restore $(Q) when this patch is applied.
Thanks.
> > -T $(obj)/boot.lds \
> > --build-id=none \
> > -o $@ $(obj)/Image.o
>
> --
> Thanks.
> -- Max
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists