lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Jul 2020 20:02:55 -0700 From: Bart Van Assche <bvanassche@....org> To: Stanley Chu <stanley.chu@...iatek.com>, linux-scsi@...r.kernel.org, martin.petersen@...cle.com, avri.altman@....com, alim.akhtar@...sung.com, jejb@...ux.ibm.com Cc: beanhuo@...ron.com, asutoshd@...eaurora.org, cang@...eaurora.org, matthias.bgg@...il.com, linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, kuohong.wang@...iatek.com, peter.wang@...iatek.com, chun-hung.wu@...iatek.com, andy.teng@...iatek.com, chaotian.jing@...iatek.com, cc.chou@...iatek.com Subject: Re: [RFC PATCH v1] scsi: ufs: Quiesce all scsi devices before shutdown On 2020-07-01 18:32, Stanley Chu wrote: > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 59358bb75014..cadfa9006972 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -8599,10 +8599,14 @@ EXPORT_SYMBOL(ufshcd_runtime_idle); > int ufshcd_shutdown(struct ufs_hba *hba) > { > int ret = 0; > + struct scsi_target *starget; > > if (!hba->is_powered) > goto out; > > + list_for_each_entry(starget, &hba->host->__targets, siblings) > + scsi_target_quiesce(starget); > + > if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba)) > goto out; Please add a comment above the list_for_each_entry() loop that explains that there is no matching scsi_target_unquiesce() call and also that SCSI commands queued after the scsi_target_quiesce() call returned will block until blk_cleanup_queue() is called (see also the blk_queue_dying() check in blk_queue_enter()). Thanks, Bart.
Powered by blists - more mailing lists