linux-kernel - [PATCH v2] leds: core: Flush scheduled work for system suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200702054500.11251-1-kai.heng.feng@canonical.com>
Date:   Thu,  2 Jul 2020 13:45:00 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     jacek.anaszewski@...il.com, pavel@....cz
Cc:     anthony.wong@...onical.com,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Dan Murphy <dmurphy@...com>,
        linux-leds@...r.kernel.org (open list:LED SUBSYSTEM),
        linux-kernel@...r.kernel.org (open list)
Subject: [PATCH v2] leds: core: Flush scheduled work for system suspend

Sometimes LED won't be turned off by LED_CORE_SUSPENDRESUME flag upon
system suspend.

led_set_brightness_nopm() uses schedule_work() to set LED brightness.
However, there's no guarantee that the scheduled work gets executed
because no one flushes the work.

So flush the scheduled work to make sure LED gets turned off.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
---
v2:
 - Use flush_work() instead.

 drivers/leds/led-class.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 3363a6551a70..cc3929f858b6 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -173,6 +173,7 @@ void led_classdev_suspend(struct led_classdev *led_cdev)
 {
 	led_cdev->flags |= LED_SUSPENDED;
 	led_set_brightness_nopm(led_cdev, 0);
+	flush_work(&led_cdev->set_brightness_work);
 }
 EXPORT_SYMBOL_GPL(led_classdev_suspend);
 
-- 
2.17.1