linux-kernel - RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <AM6PR0402MB391135EDF34C7207AC37D42DF56D0@AM6PR0402MB3911.eurprd04.prod.outlook.com>
Date:   Thu, 2 Jul 2020 06:15:05 +0000
From:   Anson Huang <anson.huang@....com>
To:     Stephen Boyd <sboyd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Dong Aisheng <dongas86@...il.com>
CC:     Peng Fan <peng.fan@....com>,
        Michael Turquette <mturquette@...libre.com>,
        "oleksandr.suvorov@...adex.com" <oleksandr.suvorov@...adex.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Leonard Crestez <leonard.crestez@....com>,
        Fabio Estevam <festevam@...il.com>,
        linux-clk <linux-clk@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Abel Vesa <abel.vesa@....com>,
        YueHaibing <yuehaibing@...wei.com>,
        Russell King <linux@...linux.org.uk>,
        Allison Randal <allison@...utok.net>,
        dl-linux-imx <linux-imx@....com>,
        Stefan Agner <stefan.agner@...adex.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Daniel Baluta <daniel.baluta@....com>,
        ARM/FREESCALE IMX / MXC ARM ARCHITECTURE 
        <linux-arm-kernel@...ts.infradead.org>,
        Aisheng Dong <aisheng.dong@....com>,
        Andy Duan <fugang.duan@....com>,
        gregkh <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Enrico Weigelt <info@...ux.net>
Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as
 module

Hi, Arnd/Stephen

> Subject: Re: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as
> module
> 
> Quoting Arnd Bergmann (2020-06-29 01:19:44)
> > On Mon, Jun 29, 2020 at 9:18 AM Dong Aisheng <dongas86@...il.com>
> wrote:
> > > On Thu, Jun 25, 2020 at 6:43 AM Stephen Boyd <sboyd@...nel.org>
> wrote:
> > > > Quoting Aisheng Dong (2020-06-23 19:59:09) Why aren't there
> > > > options to enable clk-imx6q and clk-imx6sl in the clk/imx/Kconfig
> > > > file? Those can be bool or tristate depending on if the SoC
> > > > drivers use CLK_OF_DECLARE or not and depend on the mxc-clk
> > > > library and SoC config we have in the makefile today.
> > >
> > > Yes, we can do that in clk/imx/Kconfig as follows theoretically.
> > > config CLK_IMX6Q
> > >         bool
> > >         def_bool ARCH_MXC && ARM
> > >         select MXC_CLK
> > >
> > > But we have totally 15 platforms that need to change.
> >
> > I would make that
> >
> > config CLK_IMX6Q
> >          bool "Clock driver for NXP i.MX6Q"
> >          depends on SOC_IMX6Q || COMPILE_TEST
> >          default SOC_IMX6Q
> >          select MXC_CLK
> 
> Yes, do this.

The COMPILE_TEST existing on the config will introduce some build error
on other ARCH's allyesconfig build on i.MX2/3 platforms, I received some build error report.
So in next patch series, I will drop the COMPILE_TEST for these new added clock configurations,
as I think it is NOT worth to support the COMPILE_TEST for these old legacy platforms which are
NOT supported before.

Thanks,
Anson