linux-kernel - Re: [PATCH v3] i2c: designware: platdrv: Set class based on dmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200702094958.GQ3703480@smile.fi.intel.com>
Date:   Thu, 2 Jul 2020 12:49:58 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ricardo Ribalda <ribalda@...nel.org>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wolfram Sang <wsa@...nel.org>
Subject: Re: [PATCH v3] i2c: designware: platdrv: Set class based on dmi

On Thu, Jul 02, 2020 at 12:48:08PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 02, 2020 at 11:38:32AM +0200, Ricardo Ribalda wrote:
> > Current AMD's zen-based APUs use this core for some of its i2c-buses.
> > 
> > With this patch we re-enable autodetection of hwmon-alike devices, so
> > lm-sensors will be able to work automatically.
> > 
> > It does not affect the boot-time of embedded devices, as the class is
> > set based on the dmi information.
> 
> dmi -> DMI

...and in the Subject.

> > Dmi is probed only on Qtechnology QT5222 Industrial Camera Platform
> 
> Dmi -> DMI

...and period at the end of sentence.

> > https://qtec.com/camera-technology-camera-platforms/
> 
> Use DocLink: tag.
> 
> ...
> 
> > +static const struct dmi_system_id allow_probe[] = {
> 
> allow_probe -> dw_i2c_hwmon_class_dmi
> 
> > +	{
> > +		.ident = "Qtechnology QT5222",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Qtechnology"),
> 
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "QT5222")
> 
> Comma is missed.
> 
> > +		}
> > +	},
> 
> > +
> 
> Redundant.
> 
> > +	{ }
> > +};
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

-- 
With Best Regards,
Andy Shevchenko