linux-kernel - Re: [PATCH v2 1/1] dt-bindings: MIPS: Document Ingenic SoCs binding.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Jul 2020 12:12:29 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Fabio Estevam <festevam@...il.com>
Cc:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>, linux-mips@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
        paul@...pouillou.net, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        yanfei.li@...enic.com, sernia.zhou@...mail.com,
        zhenwenjin@...il.com
Subject: Re: [PATCH v2 1/1] dt-bindings: MIPS: Document Ingenic SoCs binding.

On Mon, Jun 29, 2020 at 04:28:31PM -0300, Fabio Estevam wrote:
> On Fri, Jun 19, 2020 at 9:48 AM Thomas Bogendoerfer
> <tsbogend@...ha.franken.de> wrote:
> >
> > On Wed, Jun 03, 2020 at 02:33:54AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> > > Document the available properties for the SoC root node and the
> > > CPU nodes of the devicetree for the Ingenic XBurst SoCs.
> > >
> > > Tested-by: H. Nikolaus Schaller <hns@...delico.com>
> > > Tested-by: Paul Boddie <paul@...die.org.uk>
> > > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> > > ---
> > >
> > > Notes:
> > >     v1->v2:
> > >     1.Remove unnecessary "items".
> > >     2.Add "clocks" as suggested by Paul Cercueil.
> > >
> > >  .../bindings/mips/ingenic/ingenic,cpu.yaml         | 67 ++++++++++++++++++++++
> > >  1 file changed, 67 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> >
> > applied to mips-next.
> 
> This causes 'make dt_binding_check' to fail:
> 
> $ make dt_binding_check
>   CHKDT   Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml:
> while scanning a block scalar
>   in "<unicode string>", line 42, column 5
> found a tab character where an indentation space is expected
>   in "<unicode string>", line 46, column 1
> Documentation/devicetree/bindings/Makefile:20: recipe for target
> 'Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.example.dts'
> failed
> make[1]: *** [Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.example.dts]
> Error 1
> Makefile:1343: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2


thank you for noticing. It's my fault, I've changed spaces into tabs while
applying, which is of course wrong for yaml files... I've commited a fix
for this to mips-next and 'make dt_binding_check' now passes for me.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]