linux-kernel - Re: [PATCH v2 2/4] mfd: mt6360: implement i2c R/W with CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200702102748.GS1179328@dell>
Date:   Thu, 2 Jul 2020 11:27:48 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Gene Chen <gene.chen.richtek@...il.com>
Cc:     jic23@...nel.org, jacek.anaszewski@...il.com, pavel@....cz,
        matthias.bgg@...il.com, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, dmurphy@...com, lgirdwood@...il.com,
        Mark Brown <broonie@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Gene Chen <gene_chen@...htek.com>, shufan_lee@...htek.com,
        cy_huang@...htek.com, benjamin.chao@...iatek.com
Subject: Re: [PATCH v2 2/4] mfd: mt6360: implement i2c R/W with CRC

On Thu, 02 Jul 2020, Gene Chen wrote:

> Lee Jones <lee.jones@...aro.org> 於 2020年7月1日 週三 下午3:16寫道：
> >
> > On Fri, 19 Jun 2020, Gene Chen wrote:
> >
> > > From: Gene Chen <gene_chen@...htek.com>
> > >
> > > imlement i2c R/W with CRC when access sub-device PMIC and LDO part
> >
> > Please use proper grammar, including capital letters at the start of
> > the sentence and for abbreviations such as "I2C" and full stops.
> >
> > Also this doesn't make sense to me.  Please elaborate.
> >
> 
> ACK
> 
> > > Signed-off-by: Gene Chen <gene_chen@...htek.com>
> > > ---
> > >  drivers/mfd/Kconfig        |   1 +
> > >  drivers/mfd/mt6360-core.c  | 541 +++++++++++++++++++++++++++++----------------
> >
> > This patch is doing way too much wacky stuff all at once, making it
> > very difficult to review.  Please break it up into functional pieces
> > and submit as separate logical patches (in a set of course).
> >
> 
> If I understand correctly, I need to separate patch[2/4] but not
> entire mt6362-core.c into several patches.

Yes please.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog