linux-kernel - Re: [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ecf4032-267c-32c8-361f-2396730aaa65@canonical.com>
Date:   Thu, 2 Jul 2020 18:51:12 +0800
From:   Aaron Ma <aaron.ma@...onical.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     mapengyu@...il.com,
        Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Thinkpad-acpi devel ML <ibm-acpi-devel@...ts.sourceforge.net>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init
 when _BCL invalid

On 7/2/20 5:30 PM, Andy Shevchenko wrote:
> On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma <aaron.ma@...onical.com> wrote:
>>
>> When _BCL invalid, disable thinkpad_acpi backlight brightness control.
>>
>> brightness_enable is already checked at the beginning,
> 
>> Always print notice when enabled brightness control.
> 
> Why?
> 

Default brightness_enable = 2, so this message will always be printed as before
Actually no change here.

> ...
> 
>> +       pr_notice("thinkpad_acpi native brightness control enabled\n");
> 
> 'notice' level is quite high, why do we spam users with this?
> 

Like above.

Another reason is  most thinkpads are using native gpu driver to control
brightness, notice when thinkpad_acpi brightness is enabled.

Aaron