linux-kernel - Re: [PATCH -next] kcov: make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Jul 2020 14:27:17 +0200
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Hulk Robot <hulkci@...wei.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Maciej Grochowski <maciej.grochowski@...me>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] kcov: make some symbols static

On Thu, Jul 2, 2020 at 1:44 PM Wei Yongjun <weiyongjun1@...wei.com> wrote:
>
> Fix sparse build warnings:
>
> kernel/kcov.c:99:1: warning:
>  symbol '__pcpu_scope_kcov_percpu_data' was not declared. Should it be static?
> kernel/kcov.c:778:6: warning:
>  symbol 'kcov_remote_softirq_start' was not declared. Should it be static?
> kernel/kcov.c:795:6: warning:
>  symbol 'kcov_remote_softirq_stop' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  kernel/kcov.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/kcov.c b/kernel/kcov.c
> index 6afae0bcbac4..6b8368be89c8 100644
> --- a/kernel/kcov.c
> +++ b/kernel/kcov.c
> @@ -96,7 +96,7 @@ struct kcov_percpu_data {
>         int                     saved_sequence;
>  };
>
> -DEFINE_PER_CPU(struct kcov_percpu_data, kcov_percpu_data);
> +static DEFINE_PER_CPU(struct kcov_percpu_data, kcov_percpu_data);
>
>  /* Must be called with kcov_remote_lock locked. */
>  static struct kcov_remote *kcov_remote_find(u64 handle)
> @@ -775,7 +775,7 @@ static inline bool kcov_mode_enabled(unsigned int mode)
>         return (mode & ~KCOV_IN_CTXSW) != KCOV_MODE_DISABLED;
>  }
>
> -void kcov_remote_softirq_start(struct task_struct *t)
> +static void kcov_remote_softirq_start(struct task_struct *t)
>  {
>         struct kcov_percpu_data *data = this_cpu_ptr(&kcov_percpu_data);
>         unsigned int mode;
> @@ -792,7 +792,7 @@ void kcov_remote_softirq_start(struct task_struct *t)
>         }
>  }
>
> -void kcov_remote_softirq_stop(struct task_struct *t)
> +static void kcov_remote_softirq_stop(struct task_struct *t)
>  {
>         struct kcov_percpu_data *data = this_cpu_ptr(&kcov_percpu_data);
>
>

Reviewed-by: Andrey Konovalov <andreyknvl@...gle.com>

Thanks!