linux-kernel - Re: [PATCH] firmware: improve description of firmware_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200702124603.GA1883510@kroah.com>
Date:   Thu, 2 Jul 2020 14:46:03 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] firmware: improve description of firmware_request_nowarn

On Thu, Jun 25, 2020 at 10:02:21PM +0200, Wolfram Sang wrote:
> The doubled 'however' is confusing. Simplify the comment a little and
> reformat the paragraph.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Acked-by: Luis Chamberlain <mcgrof@...nel.org>
> ---
>  drivers/base/firmware_loader/main.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
> index ca871b13524e..8c7d9b432cb1 100644
> --- a/drivers/base/firmware_loader/main.c
> +++ b/drivers/base/firmware_loader/main.c
> @@ -838,13 +838,14 @@ EXPORT_SYMBOL(request_firmware);
>   * @name: name of firmware file
>   * @device: device for which firmware is being loaded
>   *
> - * This function is similar in behaviour to request_firmware(), except
> - * it doesn't produce warning messages when the file is not found.
> - * The sysfs fallback mechanism is enabled if direct filesystem lookup fails,
> - * however, however failures to find the firmware file with it are still
> - * suppressed. It is therefore up to the driver to check for the return value
> - * of this call and to decide when to inform the users of errors.
> + * This function is similar in behaviour to request_firmware(), except it
> + * doesn't produce warning messages when the file is not found. The sysfs
> + * fallback mechanism is enabled if direct filesystem lookup fails. However,
> + * failures to find the firmware file with it are still suppressed. It is
> + * therefore up to the driver to check for the return value of this call and to
> + * decide when to inform the users of errors.
>   **/
> +

Why the extra blank line, doesn't that break kerneldoc handling?

Can you drop that and resend with Luis's ack?

thanks,

greg k-h