linux-kernel - Re: [PATCH] Replace HTTP links with HTTPS ones: TMP513 hardware monitor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200703222056.GA35408@roeck-us.net>
Date:   Fri, 3 Jul 2020 15:20:56 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>
Cc:     jdelvare@...e.com, robh+dt@...nel.org,
        etremblay@...tech-controls.com, corbet@....net,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: TMP513 hardware
 monitor driver

On Fri, Jul 03, 2020 at 08:56:57PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>   If not .svg:
>     For each line:
>       If doesn't contain `\bxmlns\b`:
>         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>           If both the HTTP and HTTPS versions
>           return 200 OK and serve the same content:
>             Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>

Applied, after adjusting subject line to match the expected
hwmon subsystem form.

Guenter

> ---
>  Continuing my work started at 93431e0607e5.
> 
>  If there are any URLs to be removed completely or at least not HTTPSified:
>  Just clearly say so and I'll *undo my change*.
>  See also https://lkml.org/lkml/2020/6/27/64
> 
>  If there are any valid, but yet not changed URLs:
>  See https://lkml.org/lkml/2020/6/26/837
> 
>  Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml | 4 ++--
>  Documentation/hwmon/tmp513.rst                         | 4 ++--
>  drivers/hwmon/tmp513.c                                 | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml
> index 90b2fa3f7752..c17e5d3ee3f1 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml
> @@ -18,8 +18,8 @@ description: |
>    consumption.
>  
>    Datasheets:
> -  http://www.ti.com/lit/gpn/tmp513
> -  http://www.ti.com/lit/gpn/tmp512
> +  https://www.ti.com/lit/gpn/tmp513
> +  https://www.ti.com/lit/gpn/tmp512
>  
>  
>  properties:
> diff --git a/Documentation/hwmon/tmp513.rst b/Documentation/hwmon/tmp513.rst
> index 6c8fae4b1a75..f2dfc1677ad9 100644
> --- a/Documentation/hwmon/tmp513.rst
> +++ b/Documentation/hwmon/tmp513.rst
> @@ -9,13 +9,13 @@ Supported chips:
>  
>      Prefix: 'tmp512'
>  
> -    Datasheet: http://www.ti.com/lit/ds/symlink/tmp512.pdf
> +    Datasheet: https://www.ti.com/lit/ds/symlink/tmp512.pdf
>  
>    * Texas Instruments TMP513
>  
>      Prefix: 'tmp513'
>  
> -    Datasheet: http://www.ti.com/lit/ds/symlink/tmp513.pdf
> +    Datasheet: https://www.ti.com/lit/ds/symlink/tmp513.pdf
>  
>  Authors:
>  
> diff --git a/drivers/hwmon/tmp513.c b/drivers/hwmon/tmp513.c
> index df66e0bc1253..23908dc5611b 100644
> --- a/drivers/hwmon/tmp513.c
> +++ b/drivers/hwmon/tmp513.c
> @@ -5,12 +5,12 @@
>   * TMP513:
>   * Thermal/Power Management with Triple Remote and
>   * Local Temperature Sensor and Current Shunt Monitor
> - * Datasheet: http://www.ti.com/lit/gpn/tmp513
> + * Datasheet: https://www.ti.com/lit/gpn/tmp513
>   *
>   * TMP512:
>   * Thermal/Power Management with Dual Remote
>   *	and Local Temperature Sensor and Current Shunt Monitor
> - * Datasheet: http://www.ti.com/lit/gpn/tmp512
> + * Datasheet: https://www.ti.com/lit/gpn/tmp512
>   *
>   * Copyright (C) 2019 Eric Tremblay <etremblay@...tech-controls.com>
>   *