linux-kernel - Re: [PATCH 1/2] spi: Add the SPI daisy chain support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202007040618.RNxap8ao%lkp@intel.com>
Date:   Sat, 4 Jul 2020 06:32:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Adrian Fiergolski <adrian.fiergolski@...tree3d.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        geert@...ux-m68k.org, lukas@...ner.de,
        Adrian Fiergolski <adrian.fiergolski@...tree3d.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, linux-spi@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] spi: Add the SPI daisy chain support.

Hi Adrian,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on spi/for-next]
[also build test WARNING on v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Adrian-Fiergolski/spi-Add-the-SPI-daisy-chain-support/20200703-221615
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project ca464639a1c9dd3944eb055ffd2796e8c2e7639f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/spi/spi-daisy_chain.c:232:6: warning: no previous prototype for function 'spi_daisy_chain_clean' [-Wmissing-prototypes]
   void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
        ^
   drivers/spi/spi-daisy_chain.c:232:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
   ^
   static 
   1 warning generated.

vim +/spi_daisy_chain_clean +232 drivers/spi/spi-daisy_chain.c

   231	
 > 232	void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
   233	{
   234		struct spi_device *spi_dev;
   235		struct spi_daisy_chain_device *spi_chain_dev;
   236	
   237		list_for_each_entry(spi_chain_dev, daisy_chain_devs, devices) {
   238			spi_dev = spi_chain_dev->spi;
   239			spi_dev_put(spi_dev);
   240			kfree(spi_chain_dev->no_operation.tx_buf);
   241			kfree(spi_chain_dev);
   242		}
   243		list_del(daisy_chain_devs);
   244		kfree(daisy_chain_devs);
   245	}
   246	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (75369 bytes)