[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200703074025.GA2390868@kroah.com>
Date: Fri, 3 Jul 2020 09:40:25 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: stable@...r.kernel.org, linux-kernel@...r.kernel.org,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [FOR-STABLE-3.9+] sched/rt: Show the 'sched_rr_timeslice'
SCHED_RR timeslice tuning knob in milliseconds
On Fri, Jul 03, 2020 at 12:54:04PM +0530, Viresh Kumar wrote:
> From: Shile Zhang <shile.zhang@...ia.com>
>
> We added the 'sched_rr_timeslice_ms' SCHED_RR tuning knob in this commit:
>
> ce0dbbbb30ae ("sched/rt: Add a tuning knob to allow changing SCHED_RR timeslice")
>
> ... which name suggests to users that it's in milliseconds, while in reality
> it's being set in milliseconds but the result is shown in jiffies.
>
> This is obviously confusing when HZ is not 1000, it makes it appear like the
> value set failed, such as HZ=100:
>
> root# echo 100 > /proc/sys/kernel/sched_rr_timeslice_ms
> root# cat /proc/sys/kernel/sched_rr_timeslice_ms
> 10
>
> Fix this to be milliseconds all around.
>
> Cc: <stable@...r.kernel.org> # v3.9+
> Signed-off-by: Shile Zhang <shile.zhang@...ia.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Mike Galbraith <efault@....de>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Link: http://lkml.kernel.org/r/1485612049-20923-1-git-send-email-shile.zhang@nokia.com
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
What is the git commit id of this patch in Linus's tree?
thanks,
greg k-h
Powered by blists - more mailing lists