linux-kernel - Re: [PATCH RESEND] mm/page_alloc: skip setting nodemask when we are in interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOJsxLFpj1iZ8BVPwoSQJjBBtWnREQ=dVLNRV5fm4_Gvyn_DTw@mail.gmail.com>
Date:   Fri, 3 Jul 2020 10:47:20 +0300
From:   Pekka Enberg <penberg@...il.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     Muchun Song <songmuchun@...edance.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] mm/page_alloc: skip setting nodemask when we are
 in interrupt

On 03.07.20 08:34, Pekka Enberg wrote:
> >         if (cpusets_enabled()) {
> >                 *alloc_mask |= __GFP_HARDWALL;
> >                 if (!in_interrupt() && !ac->nodemask)
> >                         ac->nodemask = &cpuset_current_mems_allowed;
> >                 else
> >                         *alloc_flags |= ALLOC_CPUSET;
> >         }

On Fri, Jul 3, 2020 at 10:20 AM David Hildenbrand <david@...hat.com> wrote:
> ^ looks much cleaner as well. Do we want to add a summarizing comment?

I see no harm in adding one. I'm sure the next person starting a
journey in the maze some call the page allocator will appreciate it.

- Pekka