linux-kernel - Re: [PATCH 16/30] usb: mtu3: mtu3_trace: Function headers are not suitable for kerneldoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1593740465.23885.19.camel@mhfsdcap03>
Date:   Fri, 3 Jul 2020 09:41:05 +0800
From:   Chunfeng Yun <chunfeng.yun@...iatek.com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     <gregkh@...uxfoundation.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH 16/30] usb: mtu3: mtu3_trace: Function headers are not
 suitable for kerneldoc

On Thu, 2020-07-02 at 15:46 +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warnings:
> 
>  drivers/usb/mtu3/mtu3_trace.c:13:6: warning: no previous prototype for ‘mtu3_dbg_trace’ [-Wmissing-prototypes]
>  13 | void mtu3_dbg_trace(struct device *dev, const char *fmt, ...)
>  | ^~~~~~~~~~~~~~
The description doesn't match with the title and code changes

> 
> Cc: Chunfeng Yun <chunfeng.yun@...iatek.com>
> Cc: linux-mediatek@...ts.infradead.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/usb/mtu3/mtu3_trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/mtu3/mtu3_trace.c b/drivers/usb/mtu3/mtu3_trace.c
> index 4f5e7857ec312..155eae126e5e2 100644
> --- a/drivers/usb/mtu3/mtu3_trace.c
> +++ b/drivers/usb/mtu3/mtu3_trace.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
> -/**
> +/*
>   * mtu3_trace.c - trace support
>   *
>   * Copyright (C) 2019 MediaTek Inc.