linux-kernel - Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f1128bd916cebe01730528b5de47680d8721179.camel@perches.com>
Date:   Fri, 03 Jul 2020 02:43:51 -0700
From:   Joe Perches <joe@...ches.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Christoph Hellwig <hch@....de>, Al Viro <viro@...iv.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 16/23] seq_file: switch over direct seq_read method
 calls to seq_read_iter

On Fri, 2020-07-03 at 11:35 +0200, Miguel Ojeda wrote:
> On Fri, Jul 3, 2020 at 9:44 AM Joe Perches <joe@...ches.com> wrote:
> > And I'd generally not bother with 80 column rewrapping
> 
> Thanks for the quick answer Joe -- here I was referring to the cases
> where one needs to move all the `=`s to the right like:
> 
>  static const struct file_operations memtype_fops = {
>   .open    = memtype_seq_open,
> - .read    = seq_read,
> + .read_iter    = seq_read_iter,
>   .llseek  = seq_lseek,
>   .release = seq_release,
>  };
> 
> (I don't think there is any/many cases of 80-column rewrapping here).

OK.

I'm not much bothered much by alignments like that and
I don't see a good way to automate such conversions as
some might, as here, use spaces to align to = and most
would use tabs.