linux-kernel - Re: [PATCH 2/2] block: enable zone-append for iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN4PR0401MB3598BB905AE2F34D3D7C60749B6A0@SN4PR0401MB3598.namprd04.prod.outlook.com>
Date:   Fri, 3 Jul 2020 13:02:43 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Kanchan Joshi <joshi.k@...sung.com>,
        Damien Le Moal <Damien.LeMoal@....com>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "kbusch@...nel.org" <kbusch@...nel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hch@....de" <hch@....de>, Selvakumar S <selvakuma.s1@...sung.com>,
        Nitesh Shetty <nj.shetty@...sung.com>,
        Javier Gonzalez <javier.gonz@...sung.com>
Subject: Re: [PATCH 2/2] block: enable zone-append for iov_iter of bvec type

On 03/07/2020 08:56, Kanchan Joshi wrote:
[...]
> Yes, zonefs does not use bvec iter. But while enabling io-uring path for
> zone-append, I hit into this condition returning -EINVAL. 
> 
> Reference (from user zone-append series cover letter):
> "Append using io_uring fixed-buffer --->
> This is flagged as not-supported at the moment. Reason being, for fixed-buffer
> io-uring sends iov_iter of bvec type. But current append-infra in block-layer
> does not support such iov_iter."
> 
> And zone-append doesn't have a problem in using bvec iter as well, so
> thought that this may make infra more complete/future-proof?

As long as it's no problem for current in-tree users please keep it as is. 
Please submit this patch together with your io_uring series as a preparatory patch.