linux-kernel - Re: [PATCH v2 1/2] moduleparams: Add hexint type parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73fce393-45a5-180e-307a-4f399a31c858@amd.com>
Date:   Fri, 3 Jul 2020 15:52:35 +0200
From:   Christian König <christian.koenig@....com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org
Subject: Re: [PATCH v2 1/2] moduleparams: Add hexint type parameter

Am 03.07.20 um 15:49 schrieb Paul Menzel:
> For bitmasks printing values in hex is more convenient.
>
> Prefix with `0x` to make it clear, that it’s a hex value, and pad it
> out.
>
> Using the helper for `amdgpu.ppfeaturemask`, it will look like below.
>
> Before:
>
>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>      4294950911
>
> After:
>
>      $ more /sys/module/amdgpu/parameters/ppfeaturemask
>      0xffffbfff
>
> Cc: linux-kernel@...r.kernel.org
> Cc: amd-gfx@...ts.freedesktop.org
> Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>
> ---
> v2: Address review comments: Rename hex to hexint, and pad sizes
>
>   include/linux/moduleparam.h |  7 ++++++-
>   kernel/params.c             | 17 +++++++++--------
>   2 files changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
> index 3ef917ff0964..cff7261e98bb 100644
> --- a/include/linux/moduleparam.h
> +++ b/include/linux/moduleparam.h
> @@ -118,7 +118,7 @@ struct kparam_array
>    * you can create your own by defining those variables.
>    *
>    * Standard types are:
> - *	byte, short, ushort, int, uint, long, ulong
> + *	byte, hexint, short, ushort, int, uint, long, ulong
>    *	charp: a character pointer
>    *	bool: a bool, values 0/1, y/n, Y/N.
>    *	invbool: the above, only sense-reversed (N = true).
> @@ -448,6 +448,11 @@ extern int param_set_ullong(const char *val, const struct kernel_param *kp);
>   extern int param_get_ullong(char *buffer, const struct kernel_param *kp);
>   #define param_check_ullong(name, p) __param_check(name, p, unsigned long long)
>   
> +extern const struct kernel_param_ops param_ops_hexint;
> +extern int param_set_hexint(const char *val, const struct kernel_param *kp);
> +extern int param_get_hexint(char *buffer, const struct kernel_param *kp);
> +#define param_check_hexint(name, p) param_check_uint(name, p)
> +
>   extern const struct kernel_param_ops param_ops_charp;
>   extern int param_set_charp(const char *val, const struct kernel_param *kp);
>   extern int param_get_charp(char *buffer, const struct kernel_param *kp);
> diff --git a/kernel/params.c b/kernel/params.c
> index 8e56f8b12d8f..487261eb836f 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -233,14 +233,15 @@ char *parse_args(const char *doing,
>   	EXPORT_SYMBOL(param_ops_##name)
>   
>   
> -STANDARD_PARAM_DEF(byte,	unsigned char,		"%hhu", kstrtou8);
> -STANDARD_PARAM_DEF(short,	short,			"%hi",  kstrtos16);
> -STANDARD_PARAM_DEF(ushort,	unsigned short,		"%hu",  kstrtou16);
> -STANDARD_PARAM_DEF(int,		int,			"%i",   kstrtoint);
> -STANDARD_PARAM_DEF(uint,	unsigned int,		"%u",   kstrtouint);
> -STANDARD_PARAM_DEF(long,	long,			"%li",  kstrtol);
> -STANDARD_PARAM_DEF(ulong,	unsigned long,		"%lu",  kstrtoul);
> -STANDARD_PARAM_DEF(ullong,	unsigned long long,	"%llu", kstrtoull);
> +STANDARD_PARAM_DEF(byte,	unsigned char,		"%hhu",  kstrtou8);
> +STANDARD_PARAM_DEF(short,	short,			"%hi",   kstrtos16);
> +STANDARD_PARAM_DEF(ushort,	unsigned short,		"%hu",   kstrtou16);
> +STANDARD_PARAM_DEF(int,		int,			"%i",    kstrtoint);
> +STANDARD_PARAM_DEF(uint,	unsigned int,		"%u",    kstrtouint);
> +STANDARD_PARAM_DEF(long,	long,			"%li",   kstrtol);
> +STANDARD_PARAM_DEF(ulong,	unsigned long,		"%lu",   kstrtoul);
> +STANDARD_PARAM_DEF(ullong,	unsigned long long,	"%llu",  kstrtoull);
> +STANDARD_PARAM_DEF(hexint,	unsigned int,		"%#08x", kstrtouint);

All other indentations uses tabs, only the last one seems to use a 
space. If you touch this, then maybe make it consistent as well.

Apart from that looks good to me,
Christian.

>   
>   int param_set_charp(const char *val, const struct kernel_param *kp)
>   {