linux-kernel - Re: [PATCH 22/30] usb: typec: tcpm: fusb302: Use 'gnu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1778e11-3fe4-2987-1d44-5cce0e5013f4@roeck-us.net>
Date:   Fri, 3 Jul 2020 12:01:49 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Lee Jones <lee.jones@...aro.org>, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Yueyao Zhu <yueyao.zhu@...il.com>
Subject: Re: [PATCH 22/30] usb: typec: tcpm: fusb302: Use 'gnu_printf' format
 notation

On 7/3/20 10:41 AM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/usb/typec/tcpm/fusb302.c: In function ‘fusb302_log’:
>  drivers/usb/typec/tcpm/fusb302.c:186:2: warning: function ‘fusb302_log’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
>  186 | _fusb302_log(chip, fmt, args);
>  | ^~~~~~~~~~~~
> 
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Yueyao Zhu <yueyao.zhu@...il.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/usb/typec/tcpm/fusb302.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index b28facece43c4..99562cc65ca69 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -178,6 +178,7 @@ static void _fusb302_log(struct fusb302_chip *chip, const char *fmt,
>  	mutex_unlock(&chip->logbuffer_lock);
>  }
>  
> +__printf(2, 3)
>  static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)
>  {
>  	va_list args;
>