linux-kernel - Re: [RFC v2 0/2] Fix gfs2 readahead deadlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wj9ObgMYF8QhPCJrHBBgVXG1J75-r8CgyQm88BbfSVYcg@mail.gmail.com>
Date:   Fri, 3 Jul 2020 12:24:42 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Andreas Gruenbacher <agruenba@...hat.com>
Cc:     Matthew Wilcox <willy@...radead.org>,
        Dave Chinner <david@...morbit.com>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC v2 0/2] Fix gfs2 readahead deadlocks

On Fri, Jul 3, 2020 at 2:53 AM Andreas Gruenbacher <agruenba@...hat.com> wrote:
>
> Here's an improved version.  If the IOCB_NOIO flag can be added right
> away, we can just fix the locking in gfs2.

I see nothing wrong with this, and would be ok with getting the
patches as pulls from the gfs2 tree despite touching generic code.

Maybe wait a bit for others to comment (I see Willy already did), but
it seems like a fairly straightforward improvement, and the IOCB_NOIO
flag conceptually seems to match well with the IOCB_NOWAIT one, so
this all makes sense to me.

              Linus